Added `get_adj_matrix()` #91

Merged
meliurwen merged 3 commits from 90-feature-method-to-get-the-adjacency-matrix into dev 2 years ago
meliurwen commented 2 years ago (Migrated from github.com)
Owner

Description

See the issue related, what is done in the commits and in the changelog below.

Merge into Dev Checklist

  • Tests for the new code
  • Acceptance Testing

Changelog

  • Added a get_adj_matrix() function

(Optional) Extra info

None

<!-- # Pull/Merge Request into dev --> ## Description See the issue related, what is done in the commits and in the changelog below. ## Issues related * #90 ## Merge into Dev Checklist * [x] Tests for the new code * [x] Acceptance Testing ## Changelog * Added a `get_adj_matrix()` function ## (Optional) Extra info None
AlessandroBregoli (Migrated from github.com) requested changes 2 years ago
AlessandroBregoli (Migrated from github.com) left a comment
Owner

get_adj_matrix can't be a method of NetworkProcess. It should be a specific method of CtbnNetwork

`get_adj_matrix` can't be a method of NetworkProcess. It should be a specific method of `CtbnNetwork`
meliurwen commented 2 years ago (Migrated from github.com)
Owner

ok

ok
AlessandroBregoli (Migrated from github.com) requested changes 2 years ago
AlessandroBregoli (Migrated from github.com) left a comment
Owner

I suggest to return the reference of the matrix instead of cloning it:

self.adj_matrix.as_ref()

I suggest to return the reference of the matrix instead of cloning it: `self.adj_matrix.as_ref()`
AlessandroBregoli (Migrated from github.com) approved these changes 2 years ago
The pull request has been merged as 0eb427e5cf.
Sign in to join this conversation.
Loading…
There is no content yet.