Add the possibility to insert a seed for the random generation #33

Merged

meliurwen merged 7 commits from 12-feature-add-seed-for-random-generation into dev 3 years ago

meliurwen commented 3 years ago (Migrated from github.com)

Owner

Description

See the issue related, what is done in the commits and in the changelog below.

#12

Merge into Dev Checklist

Tests for the new code
Acceptance Testing

Changelog

It is possible to seed the generation of a trajectory

(Optional) Extra info

None

AlessandroBregoli (Migrated from github.com) reviewed 3 years ago

Cargo.toml

AlessandroBregoli (Migrated from github.com) commented 3 years ago

Owner

Why also rand_core?
It should work also without it.

src/tools.rs

AlessandroBregoli (Migrated from github.com) commented 3 years ago

Owner

Seed must be an Option

meliurwen (Migrated from github.com) reviewed 3 years ago

Cargo.toml

meliurwen (Migrated from github.com) commented 3 years ago

Owner

Yes and no, it was necessary for the function ChaCha8Rng::seed_from_u64.

Anyway, thank you for highlighting this!
With a closer look I've been able to get rid of this dependency by doing this in src/tools.rs and tests/params.rs:

- use rand_core::SeedableRng;
+ use rand_chacha::rand_core::SeedableRng;

meliurwen (Migrated from github.com) reviewed 3 years ago

src/tools.rs

meliurwen (Migrated from github.com) commented 3 years ago

Owner

Done

AlessandroBregoli (Migrated from github.com) approved these changes 3 years ago

Reviewers

The pull request has been merged as 258d016155.

Sign in to join this conversation.

bug

No Milestone

No Assignees

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: unimib-thesis-mad/reCTBN#33