Refactored `src/` and `tests/` files to be compliant to `rustfmt` #55
Merged
meliurwen
merged 4 commits from 54-refactor-make-the-code-compliant-to-rustfmt
into dev
2 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch '54-refactor-make-the-code-compliant-to-rustfmt'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Description
See the issue related, what is done in the commits and in the changelog below.
Issues related
Merge into Dev Checklist
Changelog
src/
files to be compliant torustfmt
tests/
files to be compliant torustfmt
tests/
folder forrustfmt
(Optional) Extra info
None
In my opinion, matrices was easier to read before the refactor.
Same
Same
Same
Same
Same
Same
Same
Same
Same
Same
Same
On the official
rustfmt
repo I've found that there's an ongoing issue open about the matrices topic.At the moment probably an acceptable workaround could be to set
rustfmt
to skip all the files intests/
folder and revert all the matrices.@AlessandroBregoli
I've spotted 3 different kinds of notations used for rank-3 tensors; I would suggest to use the same notation for clarity and consistency.
Here the 3 notations spotted, personally I find the notation number 2 the more clean:
If you agree @AlessandroBregoli I would also proceed to conform all the rank-3 tensors in
tests/
to the notation number 2 listed above.We can't use
ignore
option intorustfmt.toml
because it is not stable yet;on the official
rustfmt
repo and its issues is suggested to use the inner attribute#![rustfmt::skip]
instead, which is suboptimal for this use case and is also unstable on Rust, so we can't use this neither...At this point I would give up and use
cargo +nightly fmt
with onlyignore
enabled as a non-stable option.Reviewers
a5b24e9eee
.