unimib-thesis-mad
/
reCTBN
1
0
Fork 0
Code Issues 9 Pull Requests 1 Releases Activity
Labels Milestones

Solved all warnings #49

Merged
meliurwen merged 2 commits from 36-refactor-solve-the-warnings-issue into dev 2 years ago
Conversation 1 Commits 2 Files Changed 9
meliurwen commented 2 years ago (Migrated from github.com)
Owner

Description

See the issue related, what is done in the commits and in the changelog below.

Issues related

Merge into Dev Checklist

  • Tests for the new code
  • Acceptance Testing

Changelog

  • Added #![allow(non_snake_case)] in lib.rs
  • Removed some unused modules in src/
  • Fixed some negligible issues in src/
  • Solved all warnings in tests/
  • Removed all unused imported modules in tests/

(Optional) Extra info

None

<!-- # Pull/Merge Request into dev --> ## Description See the issue related, what is done in the commits and in the changelog below. ## Issues related * #36 ## Merge into Dev Checklist * [x] Tests for the new code * [x] Acceptance Testing ## Changelog * Added `#![allow(non_snake_case)]` in `lib.rs` * Removed some unused modules in `src/` * Fixed some negligible issues in `src/` * Solved all warnings in `tests/` * Removed all unused imported modules in `tests/` ## (Optional) Extra info None
AlessandroBregoli (Migrated from github.com) approved these changes 2 years ago
meliurwen commented 2 years ago (Migrated from github.com)
Owner

clippy in the CI is too much pedantic, must be nerfed (see issue #50).

All warnings has been solved for the cargo check and cargo clippy --all-targets -- -A clippy::all -W clippy::correctness commands.

So we can consider the issue #36 solved and this PR can be merged.

`clippy` in the CI is too much pedantic, must be nerfed (see issue #50). All warnings has been solved for the `cargo check` and `cargo clippy --all-targets -- -A clippy::all -W clippy::correctness` commands. So we can consider the issue #36 solved and this PR can be merged.

Reviewers

AlessandroBregoli
The pull request has been merged as eb0cf6e88d.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
AlessandroBregoli
Labels
Apply labels
Clear labels
bug
Something isn't working documentation
Improvements or additions to documentation duplicate
This issue or pull request already exists enhancement
New feature or request help wanted
Extra help is needed invalid
This doesn't seem right meta
Something related to the project itself question
Further information is requested refactor
Change in the structure urgent wontfix
This will not be worked on
No Label bug documentation duplicate enhancement help wanted invalid meta question refactor urgent wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: unimib-thesis-mad/reCTBN#49
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '36-refactor-solve-the-warnings-issue'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes