unimib-thesis-mad
/
reCTBN
1
0
Fork 0
Code Issues 9 Pull Requests 1 Releases Activity
Labels Milestones
New Issue

[Bug] Useless Node #27

Closed
opened 3 years ago by AlessandroBregoli · 0 comments
AlessandroBregoli commented 3 years ago (Migrated from github.com)
Owner

Basic info

  • Library Version:: pre alpha
  • Branch/commit:: dev/#2d7e52f8f1f2e4594c69285b157ebe744d04e117

Expected Behavior

The struct Node is usefull

Actual Behavior

The struct Node is useless

Steps to Reproduce

Exploring the code in node.rs it is easy to notice that the only functionality of struct Node is to contain a ParamEnum and a label.

Log tracebacks and/or errors shown

Irrelevant

(Optional) Extra info

I think the struct node can be safely replaced by ParamEnum simply by transferring the label to any struct that implements ParamsTrait.

## Basic info * **Library Version:**: pre alpha * **Branch/commit:**: dev/#2d7e52f8f1f2e4594c69285b157ebe744d04e117 ## Expected Behavior The `struct Node` is usefull ## Actual Behavior The `struct Node` is useless ## Steps to Reproduce Exploring the code in `node.rs` it is easy to notice that the only functionality of `struct Node` is to contain a `ParamEnum` and a `label`. ## Log tracebacks and/or errors shown Irrelevant ## (Optional) Extra info I think the `struct node` can be safely replaced by `ParamEnum` simply by transferring the label to any struct that implements `ParamsTrait`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
62-feature-rectbnpy
72-feature-add-logging-and-documentation
88-feature-add-benchmarks
dev
main
Labels
Apply labels
Clear labels
bug
Something isn't working documentation
Improvements or additions to documentation duplicate
This issue or pull request already exists enhancement
New feature or request help wanted
Extra help is needed invalid
This doesn't seem right meta
Something related to the project itself question
Further information is requested refactor
Change in the structure urgent wontfix
This will not be worked on
No Label bug documentation duplicate enhancement help wanted invalid meta question refactor urgent wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
v0.1.0
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: unimib-thesis-mad/reCTBN#27
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes