Labels Milestones

14 feature #26

Merged

AlessandroBregoli merged 6 commits from 14-feature into dev 3 years ago

Conversation 0 Commits 6 Files Changed 5

AlessandroBregoli commented 3 years ago (Migrated from github.com)

Owner

Pull/Merge Request into master dev

Description

See the issue related, what is done in the commits and in the changelog below.

Issues related

• #14

Merge into Dev Checklist

• Tests for the new code
• Acceptance Testing

Changelog

• Added a new method called validate_params to ParamsTrait
• Introduced InvalidCIM; a new kind of ParamsError
• The elements of the struct DiscreteStateContinousTimeParams are now private
• Added getters and setters for the parameters of struct DiscreteStateContinousTimeParams
• The setter method for the cim checks the validity of the cim using the validate_params method.

(Optional) Extra info

None

# Pull/Merge Request into master dev ## Description See the issue related, what is done in the commits and in the changelog below. ## Issues related * #14 ## Merge into Dev Checklist * [x] Tests for the new code * [x] Acceptance Testing ## Changelog * Added a new method called `validate_params` to `ParamsTrait` * Introduced `InvalidCIM`; a new kind of `ParamsError` * The elements of the `struct DiscreteStateContinousTimeParams` are now private * Added getters and setters for the parameters of `struct DiscreteStateContinousTimeParams` * The setter method for the cim checks the validity of the cim using the `validate_params` method. ## (Optional) Extra info None

The pull request has been merged as 2d7e52f8f1.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

bug
Something isn't working documentation
Improvements or additions to documentation duplicate
This issue or pull request already exists enhancement
New feature or request help wanted
Extra help is needed invalid
This doesn't seem right meta
Something related to the project itself question
Further information is requested refactor
Change in the structure urgent wontfix
This will not be worked on

No Label bug documentation duplicate enhancement help wanted invalid meta question refactor urgent wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: unimib-thesis-mad/reCTBN#26

Write Preview

Loading…

Cancel

Save

There is no content yet.