From 7efe6778c01cb5e2bb51b0da4d6b083f538c6c9d Mon Sep 17 00:00:00 2001
From: Luca Moretti <lucamoretti96@gmail.com>
Date: Tue, 3 Nov 2020 18:12:12 +0100
Subject: [PATCH] Added constraint based optimizer

---
 .../structure_constraint_based_estimator.py   | 40 ++-------
 .../optimizers/constraint_based_optimizer.py  | 83 +++++++++++++++++++
 2 files changed, 89 insertions(+), 34 deletions(-)
 create mode 100644 main_package/classes/optimizers/constraint_based_optimizer.py

diff --git a/main_package/classes/estimators/structure_constraint_based_estimator.py b/main_package/classes/estimators/structure_constraint_based_estimator.py
index 5cbb3d8..8a9582d 100644
--- a/main_package/classes/estimators/structure_constraint_based_estimator.py
+++ b/main_package/classes/estimators/structure_constraint_based_estimator.py
@@ -17,6 +17,7 @@ import estimators.parameters_estimator as pe
 import estimators.structure_estimator as se
 import structure_graph.sample_path as sp
 import structure_graph.structure as st
+import optimizers.constraint_based_optimizer as optimizer
 
 
 class StructureConstraintBasedEstimator(se.StructureEstimator):
@@ -202,40 +203,11 @@ class StructureConstraintBasedEstimator(se.StructureEstimator):
         Returns:
             void
         """
-        print("##################TESTING VAR################", var_id)
-        u = list(self.complete_graph.predecessors(var_id))
-        #tests_parents_numb = len(u)
-        #complete_frame = self.complete_graph_frame
-        #test_frame = complete_frame.loc[complete_frame['To'].isin([var_id])]
-        child_states_numb = self.sample_path.structure.get_states_number(var_id)
-        b = 0
-        while b < len(u):
-            #for parent_id in u:
-            parent_indx = 0
-            while parent_indx < len(u):
-                removed = False
-                #if not list(self.generate_possible_sub_sets_of_size(u, b, u[parent_indx])):
-                    #break
-                S = self.generate_possible_sub_sets_of_size(u, b, u[parent_indx])
-                #print("U Set", u)
-                #print("S", S)
-                test_parent = u[parent_indx]
-                #print("Test Parent", test_parent)
-                for parents_set in S:
-                    #print("Parent Set", parents_set)
-                    #print("Test Parent", test_parent)
-                    if self.complete_test(test_parent, var_id, parents_set, child_states_numb, tot_vars_count):
-                        #print("Removing EDGE:", test_parent, var_id)
-                        self.complete_graph.remove_edge(test_parent, var_id)
-                        u.remove(test_parent)
-                        removed = True
-                        break
-                    #else:
-                        #parent_indx += 1
-                if not removed:
-                    parent_indx += 1
-            b += 1
-        self.cache.clear()
+        optimizer_obj = optimizer.ConstraintBasedOptimizer(
+                                                            node_id = var_id,
+                                                            structure_estimator = self,
+                                                            tot_vars_count = tot_vars_count)
+        optimizer_obj.optimize_structure()
 
     def ctpc_algorithm(self):
         """
diff --git a/main_package/classes/optimizers/constraint_based_optimizer.py b/main_package/classes/optimizers/constraint_based_optimizer.py
new file mode 100644
index 0000000..7fefa02
--- /dev/null
+++ b/main_package/classes/optimizers/constraint_based_optimizer.py
@@ -0,0 +1,83 @@
+import sys
+sys.path.append('../')
+import itertools
+import json
+import typing
+
+import networkx as nx
+import numpy as np
+from networkx.readwrite import json_graph
+
+from random import choice
+
+from abc import ABC
+
+
+from optimizers.optimizer import Optimizer
+from estimators import structure_estimator as se
+import structure_graph.network_graph as ng
+
+
+class ConstraintBasedOptimizer(Optimizer):
+    """
+    Optimizer class that implement Hill Climbing Search
+    
+    """
+    def __init__(self,
+                node_id:str,
+                structure_estimator: se.StructureEstimator,
+                tot_vars_count:int
+                ):
+        """
+        Compute Optimization process for a structure_estimator
+
+        """
+        super().__init__(node_id, structure_estimator)
+        self.tot_vars_count = tot_vars_count
+        
+
+
+    def optimize_structure(self):
+        """
+        Compute Optimization process for a structure_estimator
+
+        Parameters:
+
+        Returns:
+            the estimated structure for the node
+
+        """
+        print("##################TESTING VAR################", self.node_id)
+        u = list(self.structure_estimator.complete_graph.predecessors(self.node_id))
+        #tests_parents_numb = len(u)
+        #complete_frame = self.complete_graph_frame
+        #test_frame = complete_frame.loc[complete_frame['To'].isin([self.node_id])]
+        child_states_numb = self.structure_estimator.sample_path.structure.get_states_number(self.node_id)
+        b = 0
+        while b < len(u):
+            #for parent_id in u:
+            parent_indx = 0
+            while parent_indx < len(u):
+                removed = False
+                #if not list(self.structure_estimator.generate_possible_sub_sets_of_size(u, b, u[parent_indx])):
+                    #break
+                S = self.structure_estimator.generate_possible_sub_sets_of_size(u, b, u[parent_indx])
+                #print("U Set", u)
+                #print("S", S)
+                test_parent = u[parent_indx]
+                #print("Test Parent", test_parent)
+                for parents_set in S:
+                    #print("Parent Set", parents_set)
+                    #print("Test Parent", test_parent)
+                    if self.structure_estimator.complete_test(test_parent, self.node_id, parents_set, child_states_numb, self.tot_vars_count):
+                        #print("Removing EDGE:", test_parent, self.node_id)
+                        self.structure_estimator.complete_graph.remove_edge(test_parent, self.node_id)
+                        u.remove(test_parent)
+                        removed = True
+                        break
+                    #else:
+                        #parent_indx += 1
+                if not removed:
+                    parent_indx += 1
+            b += 1
+        self.structure_estimator.cache.clear()
\ No newline at end of file